+1
On 9/17/19 8:29 AM, Martin Buchholz wrote:
Looks good to me.
At Google we also integrated tzdata2019c, and it was uneventful (good!).
But we're still using rearguard format.
The vanguard/rearguard distinction is a source of errors, so it should be
made clear what format is being used to import the files.
If you have a script to update the jdk sources, perhaps it should be
checked in to openjdk?
If these files are in vanguard format, is there a trap for those of us
doing backports to jdks that only support rearguard?
Can't think of any off the top of my head, Martin. The build tool
internally converts vanguard data into rearguard compatible, by
adjusting the standard offsets, and build into tzdb.dat (which should
even be compatible to prior JDK runtimes).
Naoto
On Tue, Sep 17, 2019 at 1:19 AM Ramanand Patil <ramanand.pa...@oracle.com>
wrote:
Hi all,
Please review the patch for tzdata2019c integration into jdk
project(jdk-14).
Webrev: http://cr.openjdk.java.net/~rpatil/8231098/14/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8231098
The patch has passed all the related testing including JCK.
Regards,
Ramanand.