On Fri, 15 Oct 2021 07:03:18 GMT, Hamlin Li <m...@openjdk.org> wrote:
>> Wu Yan has updated the pull request with a new target base due to a merge or
>> a rebase. The incremental webrev excludes the unrelated changes brought in
>> by the merge/rebase. The pull request contains four additional commits since
>> the last revision:
>>
>> - Merge branch 'master' into timezone
>> - change functions to be static
>> - replace realpath
>> - 8273111: Default timezone should return zone ID if /etc/localtime is
>> valid but not canonicalization on linux
>
> src/java.base/unix/native/libjava/TimeZone_md.c line 82:
>
>> 80:
>> 81: /*
>> 82: * remove repeated path separators ('/') in the giving 'path'.
>
> given?
Thanks, fix it.
> src/java.base/unix/native/libjava/TimeZone_md.c line 89:
>
>> 87: char *left = path;
>> 88: char *right = path;
>> 89: char *end = path + strlen(path);
>
> "char* end"? better to align with existing code style
OK, fixed it.
> src/java.base/unix/native/libjava/TimeZone_md.c line 95:
>
>> 93: for (; right < end; right++) {
>> 94: if (*right == '/' && *(right + 1) == '/') break;
>> 95: }
>
> Is this for loop necessary? Seems it's ok to merge with the nested loop below.
Thanks for your suggestion, this for loop is indeed unnecessary. Removed it.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5327
