On Mon, 1 Nov 2021 16:25:26 GMT, Pavel Rappo <pra...@openjdk.org> wrote:

>> src/java.base/share/classes/sun/util/resources/LocaleData.java line 248:
>> 
>>> 246:         private static final LocaleDataStrategy INSTANCE = new 
>>> LocaleDataStrategy();
>>> 247:         // TODO: avoid hard-coded Locales
>>> 248:         private final static Set<Locale> JAVA_BASE_LOCALES
>> 
>> Canonical modifier order is `static final`
>
> It turns out that my IDE was configured NOT to highlight missorted modifiers. 
> Once I reconfigured it, I saw these cases and some other in that same file. 
> I'll fix them all if that's okay.
> 
> My recollection is that there have been campaigns on using "the blessed 
> modifiers order". It might be that since the last such crusade the modifiers 
> have gone out of hand, and we might need to re-bless them :-)

Fixed in 2b7e0c6.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6191

Reply via email to