On Fri, 10 Dec 2021 00:27:25 GMT, Naoto Sato <na...@openjdk.org> wrote:
> The proposed fix is to address the performance degradation caused by the fix > to JDK-8275721. Some amount of the degradation cannot be avoided as the > lookup now falls back up to the bundles at Locale.ROOT. However, by lowering > the fallback priority of `regionFormatFallback` than `COMPAT`'s lookup, it > can avoid the excess bundle lookups for regions. > I also changed the test case `TestZoneTextPrinterParser.java`, which > currently iterates over 3 nested loops, i.e., all-locales x all-timezones x > 8, which is absolutely unnecessary. Made it to sample some locales. > In addition, I added a microbenchmark for the > DateFormatSymbols.getZoneStrings() method. Here is the result: > > Before the fix to JDK-8275721: > > Benchmark Mode Cnt Score Error Units > ZoneStrings.testZoneStrings ss 5 6.865 ± 0.696 s/op > > Before the proposed fix: > > Benchmark Mode Cnt Score Error Units > ZoneStrings.testZoneStrings ss 5 15.741 ± 4.300 s/op > > After the proposed fix: > > Benchmark Mode Cnt Score Error Units > ZoneStrings.testZoneStrings ss 5 9.756 ± 3.685 s/op This pull request has now been integrated. Changeset: 8dc4437d Author: Naoto Sato <na...@openjdk.org> URL: https://git.openjdk.java.net/jdk/commit/8dc4437d002db5d025b47f48e7420e3bae55bdec Stats: 73 lines in 3 files changed: 59 ins; 7 del; 7 mod 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java Reviewed-by: joehw ------------- PR: https://git.openjdk.java.net/jdk/pull/6790
