On Mon, 24 Jan 2022 10:51:00 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

>> It is already mentioned in getSystemDisplayName, getSystemTypeDescription, 
>> getSystemIcon, isRoot. Anyways, I have removed the linkage for the new 
>> addition as it will not be able to resolve.
>
> If `ShellFolder` remains mentioned, I'd rather use `<code>ShellFolder</code>` 
> as it was done originally.
> 
> I guess Sergey challenged the fact of referencing `ShellFolder`. The fact 
> that it could be `ShellFolder` rather than `File` is an implementation 
> detail. Can we drop that from the spec?
> 
> On the other hand, `ShellFolder` class, even though it's not a public API, is 
> mentioned in quite a few methods in `FileSystemView`.
> 
> I don't have a strong opinion here. Perhaps, we should scrap all the 
> references to `ShellFolder`.

Since it is mentioned in other places, I would rather not scrap it. Also, since 
in most places it is mentioned as a non-link value, I chose to modify it.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7004

Reply via email to