On Thu, 21 Apr 2022 11:47:30 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> `codespell` could just find a single typo in the files covered by the i18n 
>> alias. Just fixing the typo did not make the comment more readable, so I 
>> rewrote it slightly.
>
> src/jdk.charsets/share/classes/sun/nio/cs/ext/IBM942C.java.template line 69:
> 
>> 67: 
>> 68:         static {
>> 69:             // the mappings that need updating are
> 
> It probably meant to say "needing" but what you have is okay.

That was actually my first approach, but my English intuition failed me in 
finding the rest of the sentence. Should it be "the mappings needing update 
are", "the mappings needing an update are" or "the mappings needing updates 
are"? Neither sounded really good. So I went by a safer route. :)

-------------

PR: https://git.openjdk.java.net/jdk/pull/8335

Reply via email to