On Tue, 6 Sep 2022 12:29:23 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> I ran `codespell` on the `src/java.desktop` directory, and accepted those >> changes where it indeed discovered real typos. >> >> I ignored typos in public methods and variables. Maybe they can be fixed >> later on without much fanfare, if they are in internal classes. Typos in >> exposed APIs are likely here to stay. >> >> I will update copyright years using a script before pushing (otherwise like >> every second change would be a copyright update, making reviewing much >> harder). >> >> The long term goal here is to make tooling support for running `codespell`. >> The trouble with automating this is of course all false positives. But >> before even trying to solve that issue, all true positives must be fixed. >> Hence this PR. > > Magnus Ihse Bursie has updated the pull request incrementally with two > additional commits since the last revision: > > - Revert changes in libjpeg > - Revert changes in libfreetype I have now removed the changes to libfreetype, and also libjpeg. These were the only 3rd party source I could locate. I apologize for this PR. It was too huge. If it is of any comfort, I've learnt my lesson and won't repeat it. And once it started getting pushed down by more prioritized work, I got a bit scared about going back and look through all this for additional (unspecified) 3rd party sources, so it got left behind, hanging around. @prrace I hope this is acceptable to merge now. ------------- PR: https://git.openjdk.org/jdk/pull/8328
