On Tue, 6 Sep 2022 12:42:05 GMT, Magnus Ihse Bursie <i...@openjdk.org> wrote:
>> I ran `codespell` on the `src/java.desktop` directory, and accepted those >> changes where it indeed discovered real typos. >> >> I ignored typos in public methods and variables. Maybe they can be fixed >> later on without much fanfare, if they are in internal classes. Typos in >> exposed APIs are likely here to stay. >> >> I will update copyright years using a script before pushing (otherwise like >> every second change would be a copyright update, making reviewing much >> harder). >> >> The long term goal here is to make tooling support for running `codespell`. >> The trouble with automating this is of course all false positives. But >> before even trying to solve that issue, all true positives must be fixed. >> Hence this PR. > > Magnus Ihse Bursie has updated the pull request with a new target base due to > a merge or a rebase. The pull request now contains 46 commits: > > - Merge branch 'master' into typos-in-java.desktop > - Revert changes in libjpeg > - Revert changes in libfreetype > - Update src/java.desktop/windows/classes/sun/awt/windows/WPrinterJob.java > > Co-authored-by: Alexey Ivanov > <70774172+aivanov-...@users.noreply.github.com> > - Update src/java.desktop/unix/classes/sun/awt/X11/XBaseMenuWindow.java > > Co-authored-by: Alexey Ivanov > <70774172+aivanov-...@users.noreply.github.com> > - Update src/java.desktop/unix/classes/sun/awt/X11/XBaseMenuWindow.java > > Co-authored-by: Alexey Ivanov > <70774172+aivanov-...@users.noreply.github.com> > - Update src/java.desktop/share/classes/sun/swing/SwingUtilities2.java > > Co-authored-by: Alexey Ivanov > <70774172+aivanov-...@users.noreply.github.com> > - Update src/java.desktop/share/classes/sun/swing/SwingUtilities2.java > > Co-authored-by: Alexey Ivanov > <70774172+aivanov-...@users.noreply.github.com> > - Update src/java.desktop/share/classes/sun/awt/image/ImagingLib.java > > Co-authored-by: Alexey Ivanov > <70774172+aivanov-...@users.noreply.github.com> > - Update src/java.desktop/share/classes/sun/awt/image/ImagingLib.java > > Co-authored-by: Alexey Ivanov > <70774172+aivanov-...@users.noreply.github.com> > - ... and 36 more: https://git.openjdk.org/jdk/compare/6a1e98cb...1ce28314 I see now that Phil cryptically said: > Regarding changes in gif + freetype diff --git a/src/java.desktop/share/native/libawt/awt/image/gif/gifdecoder.c b/src/java.desktop/share/native/libawt/awt/image/gif/gifdecoder.c \ \ diff --git a/src/java.desktop/share/native/libfontmanager/freetypeScaler.c b/src/java.desktop/share/native/libfontmanager/freetypeScaler.c \ \ Please exclude ALL 3rd party libraries from this PR. That might be interpreted as stating that `gifdecoder.c` is 3rd party source code (although that was by no means clear to me the first time I read it). I'll revert the changes in that file, and also `src/java.desktop/share/native/libfontmanager/freetypeScaler.c`. ------------- PR: https://git.openjdk.org/jdk/pull/8328
