On Fri, 22 Nov 2024 00:50:45 GMT, Alexander Zvegintsev <azveg...@openjdk.org>
wrote:
> I think the removal of the use of the `AccessControlException` should also be
> part of this PR.
>
> there is only one usage:
>
> ```
> ./src/java.desktop/share/classes/java/awt/Dialog.java:36:import
> java.security.AccessControlException;
> ./src/java.desktop/share/classes/java/awt/Dialog.java:1597: } catch
> (@SuppressWarnings("removal") AccessControlException ace) {
> ```
>
> And it seems that the `java.awt.Dialog#checkModalityPermission()` has became
> obsolete.
I deliberately left these alone, because it is part of removing most
AWTPermissions which I have partially prepared already for a separate PR.
The fix will come soon, perhaps tomorrow, perhaps Monday.
> src/java.desktop/share/classes/java/awt/Component.java line 8949:
>
>> 8947: private void readObject(ObjectInputStream s)
>> 8948: throws ClassNotFoundException, IOException
>> 8949: {
>
> `@SuppressWarnings("removal")` can be removed
ok
> src/java.desktop/share/classes/java/awt/MenuComponent.java line 428:
>
>> 426: private void readObject(ObjectInputStream s)
>> 427: throws ClassNotFoundException, IOException, HeadlessException
>> 428: {
>
> `@SuppressWarnings("removal")` can be removed
ok
> src/java.desktop/share/classes/javax/swing/UIDefaults.java line 1116:
>
>> 1114: * parameters to the static method in class c
>> 1115: */
>> 1116: @SuppressWarnings("removal")
>
> Suggestion:
ok
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22308#issuecomment-2492838871
PR Review Comment: https://git.openjdk.org/jdk/pull/22308#discussion_r1853256344
PR Review Comment: https://git.openjdk.org/jdk/pull/22308#discussion_r1853256435
PR Review Comment: https://git.openjdk.org/jdk/pull/22308#discussion_r1853256560
