On Thu, 21 Aug 2025 01:30:52 GMT, Shaojin Wen <s...@openjdk.org> wrote:

>> By adding the JVM startup parameters `-XX:+UnlockDiagnosticVMOptions 
>> -XX:+PrintInlining` and analyzing the printed log information, and found 
>> that the code size of the j.t.f.DateTimePrintContext::adjust method is 382, 
>> which is greater than 325, causing inlining failure.
>> 
>> 
>> @ 7   java.time.format.DateTimePrintContext::adjust (382 bytes)   failed to 
>> inline: hot method too big
>> 
>> 
>> By splitting the code into `common/uncommon`, and moving the uncommon code 
>> into adjust0, the adjust method is kept small and can be inlined by the C2 
>> optimizer.
>
> Shaojin Wen has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - code style
>  - implNote before param, from @RogerRiggs

Looks fine

-------------

Marked as reviewed by rriggs (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26633#pullrequestreview-3141789230

Reply via email to