On Mon, 19 Jan 2026 11:30:51 GMT, Liam Miller-Cushon <[email protected]> wrote:

>> Liam Miller-Cushon has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Switch to @apiNote
>
> src/java.base/share/classes/java/lang/String.java line 1169:
> 
>> 1167:         while (sp < sl) {
>> 1168:             char c = StringUTF16.getChar(val, sp++);
>> 1169:             if (c > 0x80) {
> 
> The handling of `c == 0x80` isn't consistent with `encodedLengthASCII`, but 
> also it doesn't matter because this is redundant with the `isHighSurrogate` 
> test below.
> 
> Thinking about this a little more, `encodedLength8859_1` and 
> `encodedLengthASCII` are identical, and could be merged together.

I have tentatively merged `encodedLength8859_1` and `encodedLengthASCII`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28454#discussion_r2704396396

Reply via email to