> Can I please get a review of this test-only change which proposes to improve > the debuggability of the `test/jdk/sun/nio/cs/TestStringCodingUTF8.java` test? > > This test fails intermittently in our CI in older update releases with errors > like: > > java.lang.RuntimeException: getBytes(csn) failed > at TestStringCodingUTF8.test(TestStringCodingUTF8.java:111) > at TestStringCodingUTF8.test(TestStringCodingUTF8.java:85) > at TestStringCodingUTF8.main(TestStringCodingUTF8.java:41) > > > It's not clear from the failures whether this is a test specific issue or > some genuine issue in some specific release of the JDK. Since the test uses a > `Random` instance to generate the data to test, it isn't easy to reproduce it > either. > > The change in this PR proposes to use the `RandomFactory` test library which > is equipped with printing the seed used by the `Random` instance. If the test > fails in future, the seed should help reproduce the test data that ran into > the failure. The change also improves the error messages in the test and > updates the `Collections.shuffle()` call to pass it the same `Random` > instance that's being used in the test. > > The test continues to pass with this change. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai).
Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - print mismatched content - merge latest from master branch - 8386810: Improve debuggability of test/jdk/sun/nio/cs/TestStringCodingUTF8.java ------------- Changes: - all: https://git.openjdk.org/jdk/pull/31548/files - new: https://git.openjdk.org/jdk/pull/31548/files/ec3fb826..4a264f71 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=31548&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=31548&range=00-01 Stats: 979 lines in 33 files changed: 759 ins; 50 del; 170 mod Patch: https://git.openjdk.org/jdk/pull/31548.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/31548/head:pull/31548 PR: https://git.openjdk.org/jdk/pull/31548
