Nice one.  Thanks a lot.

A few minor objections, though.

First, the right term is not ``nonfontenc'' -- you do use fontenc in
the GBK code.  The right term should be ``other'', following ISO 2022
terminology.

I don't agree with the way you reuse the Ck slot for an ``other''
encoding; the way you do it, you won't be able to implement the
``return to previous charset'' escape sequence.  Instead, you should
add a new slot to the ISO 2022 state structure, say is->other.
Initially, is->other is NULL; when an ``other'' charset is invoked,
is->other points at said charset.  THe ISO 2022 parser checks
is->other, and skips all normal processing if it is non-NULL.

Finally, I object with the stacks being static.  I've gone to quite a
bit of effort to make the ISO 2022 parser reentrant (there's nothing
that prevents multiple ISO 2022 parsers being used simultaneously),
and that means that global variables should be avoided.  You should
put the stack in the ISO 2022 state, and allocate/free it on demand.

Thanks again,

                                        Juliusz
_______________________________________________
I18n mailing list
[EMAIL PROTECTED]
http://XFree86.Org/mailman/listinfo/i18n

Reply via email to