On Thu, 31 Jan 2008, David Brownell wrote:
> On Thursday 31 January 2008, Guennadi Liakhovetski wrote:
> > +/* This is only temporary - should go with 2.6.26. Only introduced now
> > + * to avoid a sequence of strcmp() calls and just compare in a loop */
> > +struct pca953x_desc {
> > + unsigned int gpios;
> > + char *name;
> > +};
>
> This is a bit sub-optimal; if it were the same as i2c_device_id then
> less code would need to change later. So I'll probably tweak that bit
> before sending it on.
Well, you said i2c_device_id is going to look like
struct i2c_device_id {
char name[I2C_NAME_SIZE];
kernel_ulong_t driver_data; /* Data private to the driver */
};
And I only have a (const) statically initialized array of such structs.
So, what would be the difference?
Thanks
Guennadi
---
Guennadi Liakhovetski
_______________________________________________
i2c mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/i2c
