Hi,
> + #ifdef CONFIG_I2C_DEBUG_BUS
> + printk("I2C: <i2c_imx_bus_busy>\n");
> + #endif
>
Using a macro that evaluates to nothing in case CONFIG_I2C_DEBUG_BUS is
not defined would make the code much more readable.
> + temp = readb ( i2c_imx->base + IMX_I2C_I2CR);
> + temp |= I2CR_MSTA;
>
inconsistent indentation with tabs and spaces (througout the whole patch).
> + if (!i2c_imx) {
> + printk("I2C: can't allocate inteface!\n");
^^
typo.
Lothar Wassmann
--
___________________________________________________________
Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996
www.karo-electronics.de | [EMAIL PROTECTED]
___________________________________________________________
_______________________________________________
i2c mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/i2c
