On Fri, 25 Apr 2008 09:58:12 -0700, Troy Kisky wrote: > Interrupts are enabled at the point where > the DAVINCI_I2C_IVR_REG is read, so unless > an interrupt happened just at that moment, > no interrupt would be pending. Even though > documentation implies you should do this, > I see no reason. If slave support is added, > this read would cause a hard to reproduce bug. > > Signed-off-by: Troy Kisky <[EMAIL PROTECTED]> > Signed-off-by: Kevin Hilman <[EMAIL PROTECTED]> > --- > drivers/i2c/busses/i2c-davinci.c | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-davinci.c > b/drivers/i2c/busses/i2c-davinci.c > index 318579b..d9752ae 100644 > --- a/drivers/i2c/busses/i2c-davinci.c > +++ b/drivers/i2c/busses/i2c-davinci.c > @@ -240,7 +240,6 @@ i2c_davinci_xfer_msg(struct i2c_adapter *adap, struct > i2c_msg *msg, int stop) > struct davinci_i2c_dev *dev = i2c_get_adapdata(adap); > struct davinci_i2c_platform_data *pdata = dev->dev->platform_data; > u32 flag; > - u32 stat; > u16 w; > int r; > > @@ -264,9 +263,6 @@ i2c_davinci_xfer_msg(struct i2c_adapter *adap, struct > i2c_msg *msg, int stop) > init_completion(&dev->cmd_complete); > dev->cmd_err = 0; > > - /* Clear any pending interrupts by reading the IVR */ > - stat = davinci_i2c_read_reg(dev, DAVINCI_I2C_IVR_REG); > - > /* Take I2C out of reset, configure it as master and set the > * start bit */ > flag = DAVINCI_I2C_MDR_IRS | DAVINCI_I2C_MDR_MST | DAVINCI_I2C_MDR_STT;
Applied, thanks. -- Jean Delvare _______________________________________________ i2c mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/i2c
