On Saturday 10 May 2008, Jean Delvare wrote:
> > amd_ec_write(smbus, AMD_SMB_ADDR, addr << 1);
> > amd_ec_write(smbus, AMD_SMB_PRTCL, protocol);
> >
> > + /* FIXME this discards status from ec_read() ... */
> > amd_ec_read(smbus, AMD_SMB_STS, temp + 0);
>
> Same is true of almost all amd_ec_write and amd_ec_read calls, so I
> don't get the point of adding a comment for this one occurrence in
> particular.
>
> >
> > if (~temp[0] & AMD_SMB_STS_DONE) {
I updated that comment. The issue is that temp[0] will
have random stack garbage at that point, so the rest of
that routine is at best dicey.
_______________________________________________
i2c mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/i2c
