On Fri, 29 Aug 2008 11:09:18 +0200, Rodolfo Giometti wrote: > On Fri, Aug 29, 2008 at 02:04:09AM -0700, Andrew Morton wrote: > > On Fri, 29 Aug 2008 10:45:33 +0200 Jean Delvare <[EMAIL PROTECTED]> wrote: > > > > > Hi Andrew, > > > > > > On Fri, 29 Aug 2008 00:52:17 -0700, Andrew Morton wrote: > > > > drivers/i2c/busses/i2c-ocores.c: In function 'oc_setreg': > > > > drivers/i2c/busses/i2c-ocores.c:68: error: implicit declaration of > > > > function 'iowrite8' > > > > drivers/i2c/busses/i2c-ocores.c: In function 'oc_getreg': > > > > drivers/i2c/busses/i2c-ocores.c:73: error: implicit declaration of > > > > function 'ioread8' > > > > drivers/i2c/busses/i2c-ocores.c: In function 'ocores_i2c_probe': > > > > drivers/i2c/busses/i2c-ocores.c:243: error: implicit declaration of > > > > function 'ioremap' > > > > drivers/i2c/busses/i2c-ocores.c:243: warning: assignment makes pointer > > > > from integer without a cast > > > > drivers/i2c/busses/i2c-ocores.c:279: error: implicit declaration of > > > > function 'iounmap' > > > > > > > > Some missing Kconfig dependency. s390 can't do IO :) > > > > > > Where is this failure happening? In Linus' tree, I2C depends on > > > HAS_IOMEM (which s390 doesn't have), and I2C_OCORES depends on I2C. So > > > I fail to see how a make allmodconfig can select I2C_OCORES on s390. > > > Can you share the .config file? > > > > > > > <bisects> > > > > It's > > power-support-for-texas-instruments-bq27x00-battery-managers.patch, > > which does > > > > --- > > a/drivers/power/Kconfig~power-support-for-texas-instruments-bq27x00-battery-managers > > +++ a/drivers/power/Kconfig > > @@ -62,4 +62,17 @@ config BATTERY_PALMTX > > help > > Say Y to enable support for the battery in Palm T|X. > > > > +config BATTERY_BQ27x00 > > + tristate "BQ27x00 battery driver" > > + help > > + Say Y here to enable support for batteries with BQ27000 or > > + BQ27200 chip. > > + > > +config BATTERY_BQ27200 > > + bool "BQ27200 battery driver" > > + depends on BATTERY_BQ27x00 > > + select I2C > > + help > > + Say Y here to enable support for batteries with BQ27200(I2C) chip. > > + > > > > > > which enables I2C stuff in s390 allmodconfig. Should it be `depends on'? > > Yes. > > depends on I2C && BATTERY_BQ27x00 >
Yes please. Ideally nothing but arch files should ever select I2C. -- Jean Delvare _______________________________________________ i2c mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/i2c
