Hi Uwe,
Note: patches to i2c bus drivers are better sent to the i2c mailing
list (Cc'd.)
On Tue, 2 Sep 2008 23:15:56 +0200, Uwe Kleine-König wrote:
> __devexit for i2c_powermac_probe is obviously wrong. In the definition
> of struct platform_driver i2c_powermac_driver the remove function
> i2c_powermac_remove is wrapped in __devexit_p, so it should be defined
> using __devexit.
>
> Signed-off-by: Uwe Kleine-König <[EMAIL PROTECTED]>
> Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
> Cc: Paul Mackerras <[EMAIL PROTECTED]>
> Cc: Jean Delvare <[EMAIL PROTECTED]>
> ---
> drivers/i2c/busses/i2c-powermac.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-powermac.c
> b/drivers/i2c/busses/i2c-powermac.c
> index 22f6d5c..0e7b1c6 100644
> --- a/drivers/i2c/busses/i2c-powermac.c
> +++ b/drivers/i2c/busses/i2c-powermac.c
> @@ -180,7 +180,7 @@ static const struct i2c_algorithm i2c_powermac_algorithm
> = {
> };
>
>
> -static int i2c_powermac_remove(struct platform_device *dev)
> +static int __devexit i2c_powermac_remove(struct platform_device *dev)
> {
> struct i2c_adapter *adapter = platform_get_drvdata(dev);
> struct pmac_i2c_bus *bus = i2c_get_adapdata(adapter);
> @@ -200,7 +200,7 @@ static int i2c_powermac_remove(struct platform_device
> *dev)
> }
>
>
> -static int __devexit i2c_powermac_probe(struct platform_device *dev)
> +static int __devinit i2c_powermac_probe(struct platform_device *dev)
> {
> struct pmac_i2c_bus *bus = dev->dev.platform_data;
> struct device_node *parent = NULL;
Looks good, patch applied. Thanks for your contribution.
--
Jean Delvare
_______________________________________________
i2c mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/i2c
