> Here is the patch against 2.6.26.5. > Please tell me if I did something very wrong ;)
I'm just about to leave the office, so just the first notes. Will have a
deeper look later this evening...
> +static void pca9665_reset(void *pd)
> +{
> + struct i2c_algo_pca_data *adap = pd;
> + pca_outw(adap,I2C_PCA_INDPTR,I2C_PCA_IPRESET);
> + pca_outw(adap,I2C_PCA_IND,0xA5);
> + pca_outw(adap,I2C_PCA_IND,0x5A);
CodingStyle issues (space after comma)...
> + if (pca_data->i2c_chip_type != I2C_PCA_CHIP_9564 &&
> pca_data->i2c_chip_type != I2C_PCA_CHIP_9665 ) {
Line is longer than 80 chars. Please be sure to have run checkpatch.pl
before submitting.
> +
Trailing whitespaces here (and in some other places).
> + int minTLow, minTHi;
This style of naming is at least unusual in kernel. Maybe min_tlow?
So much for now, more later...
Wolfram
--
Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de
Pengutronix - Linux Solutions for Science and Industry
signature.asc
Description: Digital signature
_______________________________________________ i2c mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/i2c
