Dear Authors,
I read the draft, here are some comments, hope it help.
The comments are mainly based on 01, but most of them apply to 02.
General comments:
According to the recent discussion about "Multi-Headed Control", seems there
needs to define the unit of the "data" that will be changed by the I2RS clients
in this rib im document.
Specific Comments:
1. Section 6
<mpls-route> ::= <MPLS> <MPLS_LABEL>
<mac-route> ::= <IEEE_MAC> ( <MAC_ADDRESS> )
1.1 Seems the brackets of " ( <MAC_ADDRESS> )" are redundant.
1.2 What's the <MPLS> and <IEEE_MAC> stands for here? The route type?
If so, why not apply this to the <ipv4-prefix> and <ipv6-prefix> as well ,hence
<ipv4-prefix> ::= <IPV4_ADDRESS> <IPV4_ADDRESS_LENGTH> would be <ipv4-prefix>
::= <IPv4> <IPV4_ADDRESS> <IPV4_ADDRESS_LENGTH>, and
<ipv6-prefix> ::= <IPV6_ADDRESS> <IPV6_ADDRESS_LENGTH> would be <ipv6-prefix>
::= <IPv6> <IPV6_ADDRESS> <IPV6_ADDRESS_LENGTH>
2. Section 6
<rib-family> ::= <IPV4_RIB_FAMILY> | <IPV6_RIB_FAMILY> |
<MPLS_RIB_FAMILY> | <IEEE_MAC_RIB_FAMILY>,
and
<match> ::= <ipv4-route> | <ipv6-route> | <mpls-route> |
<mac-route> | <interface-route>
There are four rib families defined, but there are five types route, so which
rib family does the interface-route belong to? Seems there needs a
<INTERFACE_RIB_FAMILY>.
3. Section 6
<route> ::= <match> <nexthop-list>
[<route-attributes>]
[<route-vendor-attributes>]
When a route was installed in the RIB, there should be an indication to
identify from which protocols (e.g., ISIS, OSPF, BGP, I2RS, CLI etc.) the route
is. So there may need a <Origin> attribute.
Maybe similar like this:
<Origin> ::= <RIP> | <OSPF> | <ISIS> | <BGP> | <LDP> | <RSVP-TE> | <CLI> |
<I2RS>
How do you think?
4. Section 6
<tunnel-type> ::= <IP> | <MPLS> | <GRE> | <VxLAN> | <NVGRE>
Should the <IP> be more specific to <IPv4> and <IPv6>? What does the <IP>
really intend for? UDP, TCP? And there may be other tunnel, e.g., l2tp.
5. Section 7.1
AS-data information and AS length comparison are BGP related stuff, this should
be transparent to RIB manager. I am not sure whether this belongs to Rib info
model.
Best regards,
Mach
_______________________________________________
i2rs mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/i2rs
