Thanks Tom for follow up comments, please see my reply inline below.
-----邮件原件-----
发件人: tom petch [mailto:[email protected]]
发送时间: 2019年8月24日 0:39
收件人: Qin Wu <[email protected]>; [email protected]
抄送: Susan Hares <[email protected]>
主题: Re: I-D Action: draft-ietf-i2rs-yang-l2-network-topology-09.txt
Qin
I said that I might look some more and I have.
I still think that you need references for 802.1ad and 802.1ah. It is not a
question of whether or not they are imported, it is where does the reader go to
find out more about e.g. QinQ and that needs nailing down to a specific
document, and in the case of the IEEE, that needs a date, as you give for
802.1Q.
Talking of which, I find that Rob imports that IEEE module from a different
document; 802.1Qcp; um.
[Qin]: Okay, will add all these IEEE related references.
And, in the same vein, I would like a reference for LLDP.
[Qin]:I think it is IEEE 802.1AB and will add.
/defned/defined/
[Qin]: Thanks.
leaf rate
what are the units?
[Qin]: We select Mbps as units and will add.
leaf maximum-frame-size {
what is a frame, what headers are included and what not? This is a fraught
topic
[Qin]: It is layer 2 frame, it could be Ethernet frame, it could be PPP frame,
they are all layer 2 frame.
/ternimation point/termination point/
[Qin]: Fixed, thanks.
leaf vlan-name {
any constraints on length or character set? I like them although am conscious
that some YANG doctors do not.
[Qin]:Good point, the constraint is 32 characters and will length constraint,
thanks.
leaf encapsulation {
the description exceeds the permissible line length for an RFC
[Qin]:Fixed, thanks.
type enumeration {
enum in-use {
value 0;
again a personal preference - I like to see zero kept for a special purpose
(e.g. cannot be determined) unless there is a strong reason to use it (e.g. it
is what the protocol has been using for years)
[Qin]:Good, I will skip value 0, thanks!
Tom Petch
----- Original Message -----
From: "Qin Wu" <[email protected]>
Sent: Monday, August 19, 2019 8:08 AM
> v-09 is posted to address Tom's comments.
> The diff is:
>
https://www.ietf.org/rfcdiff?url2=draft-ietf-i2rs-yang-l2-network-topolo
gy-09
> Becuase datatracker pyang integration tool issue, Data model
"ieee802-dot1q-types" can not been found
> And imported into the model defined in this draft.
>
> -Qin
> -----邮件原件-----
> 发件人: I-D-Announce [mailto:[email protected]] 代表
[email protected]
> 发送时间: 2019年8月19日 15:04
> 收件人: [email protected]
> 抄送: [email protected]
> 主题: I-D Action: draft-ietf-i2rs-yang-l2-network-topology-09.txt
>
>
> A New Internet-Draft is available from the on-line Internet-Drafts
directories.
> This draft is a work item of the Interface to the Routing System WG of
the IETF.
>
> Title : A YANG Data Model for Layer-2 Network
Topologies
> Authors : Jie Dong
> Xiugang Wei
> Qin Wu
> Mohamed Boucadair
> Anders Liu
> Filename : draft-ietf-i2rs-yang-l2-network-topology-09.txt
> Pages : 31
> Date : 2019-08-19
>
> Abstract:
> This document defines a YANG data model for Layer 2 network
> topologies.
>
> Editorial Note (To be removed by RFC Editor)
>
> Please update these statements within the document with the RFC
> number to be assigned to this document:
>
> o "This version of this YANG module is part of RFC XXXX;"
>
> o "RFC XXXX: A YANG Data Model for Layer-2 Network Topologies";
>
> o reference: RFC XXXX
>
> Please update the "revision" date of the YANG module.
>
>
> The IETF datatracker status page for this draft is:
>
https://datatracker.ietf.org/doc/draft-ietf-i2rs-yang-l2-network-topolog
y/
>
> There are also htmlized versions available at:
>
https://tools.ietf.org/html/draft-ietf-i2rs-yang-l2-network-topology-09
>
https://datatracker.ietf.org/doc/html/draft-ietf-i2rs-yang-l2-network-to
pology-09
>
> A diff from the previous version is available at:
>
https://www.ietf.org/rfcdiff?url2=draft-ietf-i2rs-yang-l2-network-topolo
gy-09
>
>
> Please note that it may take a couple of minutes from the time of
submission until the htmlized version and diff are available at tools.ietf.org.
>
> Internet-Drafts are also available by anonymous FTP at:
> ftp://ftp.ietf.org/internet-drafts/
>
> _______________________________________________
> I-D-Announce mailing list
> [email protected]
> https://www.ietf.org/mailman/listinfo/i-d-announce
> Internet-Draft directories: http://www.ietf.org/shadow.html or
ftp://ftp.ietf.org/ietf/1shadow-sites.txt
>
_______________________________________________
i2rs mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/i2rs
