Improve how CloseConnection() tests for closeable connection
------------------------------------------------------------

         Key: IBATISNET-32
         URL: http://issues.apache.org/jira/browse/IBATISNET-32
     Project: iBatis for .NET
        Type: Improvement
    Versions: DataMapper 1.1    
 Environment: [assembly: AssemblyVersion("1.1.458")]
    Reporter: Ron Grabowski
    Priority: Trivial


Line 183 contains the following code before trying to close a connection:

 if ( (_connection != null) && (_connection.State == ConnectionState.Open) )

It may be better to check for a non-closed connection to handle other 
connection states like ConnectionState.Broken:

 if ( (_connection != null) && (_connection.State != ConnectionState.Closed) )

There's also an extra semi-colon at the end of line 190;

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira

Reply via email to