[ http://issues.apache.org/jira/browse/IBATISNET-76?page=comments#action_66823 ] Roberto Rabe commented on IBATISNET-76: ---------------------------------------
Wow Ron! Great catches! > Fixes to 6/1/2005 documentation > ------------------------------- > > Key: IBATISNET-76 > URL: http://issues.apache.org/jira/browse/IBATISNET-76 > Project: iBatis for .NET > Type: Improvement > Reporter: Ron Grabowski > Assignee: Gilles Bayon > Priority: Trivial > > -- 1 -- > Page 8 of the 'DataMapper Guide 1-2.pdf' has a typo: > <typeAlias alias="Product" type="Example.Domain.Product, Example.Domain" /> > <alias> > <cacheModel id="productCache" type="LRU"> > <flushInterval hours="24"/> > <property name="size" value="1000" /> > </cacheModel> > </alias> > -- 2 -- > Page 16 doesn't have the e in LastName highlighted in blue > -- 3 -- > Page 18 is passing in a parameterClass="int" but isn't referencing it. > -- 4 -- > Page 19 Example 3.16 has a lot of dots in it. For example: > [nullValue="null.value.replacement"] > [size="column.size"] > Doesn't size just accept a number? > size="300" > A lot of the other properties use the same confusion . notation. The first > parameter is missing a closing /> > When I first started using IBatisNet, I wasn't sure how to pass in a null > value for a string. I thought I had to use a special string value like > "noemail" or "null". It turns out all I had to do was pass in null. Example > 3.20 is another example of this. If I want to insert a null value I don't > have to use NO_ENTRY. I can just set description to null and pass that in. > -- 5 -- > Page 22 has parameterClass as "product" when it should probably be "Product". > Its probably not a good idea to include the semi-colons on the example. > They're not supported by every database. > -- 6 -- > Page 23 .Net does not have an "Integer" or "System.Integer" type. It should > be Int32. > -- 7 -- > Page 24 HashTable should be Hashtable > -- 8 -- > Page 25 Confusing "column.index" notation again. I think it should be "column > index". > -- 9 -- > Page 29 __guidProperty should be _guidProperty > -- 10 -- > Page 34 Section 3.5.7 S 3.33 I bet the public properties on the Product class > are really Id and Description instead of id and description. Does casing > matter? > -- 11 -- > Page 35 I know "value" is a valid marker token but is "val" one too? > IBatisNet.DataMapper.Configuration.ResultMapping.ResultProperty.cs:260 > -- 12 -- > Page 43 Its not currently possible to write your own cache implementation. > -- 13 -- > Page 45 <property name="CacheSize" value="100"/> > Page 8 <property name="size" value="1000" /> > -- 14 -- > Page 50 java.util.List should be IList > -- 15 -- > Page 50 Advanced examples for the iterate tag ??? > <iterate> > <iterate> > <iterate> > </iterate> > -- 16 -- > Page 51 ...was equal to 'LIKE' and the... > -- 17 -- > Page 56 Incorrect <settings> node. Should be <properties> ??? > -- 18 -- > Page 61 nt16 should be Int16 > -- 19 -- > Page 65 Explain that you don't always have to create your own singelton > Mapper class. You can use IBatisNet.DataMapper.Mapper.Instance(). Someone > posted their sample code to the mailing list and I think their Mapper class > was a copied and pasted from the docs... > -- 20 -- > Page 69 Include VB.Net syntax arghh ??? > Document the interface members? i.e. 'int Update(string, object)' returns > number of rows updated, QueryForMap is an alias to QueryForDictionary, etc. > Hrmmm, the next several pages go into detail what each of the methods do. I > think that's ok. > -- 21 -- > Page 70 Show example of QueryWithRowDelegate ??? (ok...Page 76) > Explain that you can't cast the returned IList to a strongly typed collection > unless you specify a listClass attribute in the <statement> > -- 22 -- > Page 71 "that used skipResults" should read "that uses skipResults" > -- 23 -- > Page 74 make a note that the "using" syntax automatically calls > RollBackTransaction if an exception occurs (does it ???) > -- 24 -- > General questions/comments: > -- 25 -- > What does "useEmbedStatementParams" do? > -- 26 -- > Write a small blurb and example showing how to get the underlying > IDbConnection object and make "normal" ADO.Net calls using that. > -- 27 -- > Explain that if you are using just the DataMapper, you don't need a > dao.config file. > Data Access Guide-1.6.pdf: > -- 28 -- > Page 6 Update versions of Dependencies > -- 29 -- > Page 8: Example 3.2 is missing parent node ??? Shouldn't it be: > <properties> > <property key="userid" value="IBatisNet" /> > <property key="password" value="test" /> > <property key="database" value="iBatisNet" /> > <property key="datasource" value="(local)\NetSDK" /> > </properties > -- 30 -- > Page 20 file:\\ should be file:// > -- 31 -- > Page 22 should daoManager.BeginTransaction() be inside the try block? > -- 32 -- > Page 23 I think the numbers after Connection should be taken off to not > confuse people. Using connection pooling, only one network connection is > opened to the database (that's confusing too hrmmm...) > -- 33 -- > Page 27 Section 6.4 contains very good examples! > -- 34 -- > Page 28 "public void Delete(Account account) {, DaoManager" what is ", > DaoManager" ??? > -- 35 -- > Page 29 this.GetContext() is inside the try block; on Page 28 its not > -- 36 -- > Page 29 The mailing list(s) likes to talk about a "Service" tier. Should > AccountDaoUsage be renamed to AccountService or AccountManager? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
