At Thu, 24 Dec 2009 16:59:12 -0200, Henrique de Moraes Holschuh wrote: > > On Wed, 23 Dec 2009, Takashi Iwai wrote: > > At Tue, 22 Dec 2009 17:38:58 -0200, > > Henrique de Moraes Holschuh wrote: > > > I won't in this case. I think I will cook up a patch to disable the entire > > > mixer subsystem in thinkpad-acpi if CONFIG_SND is not available. I don't > > > like the depends on SND though. > > > > That's also not so trivial unless you give any dependency in Kconfig. > > Without a restriction, THINKPAD_ACPI=y and SND=m can be chosen. > > "depends on SND || SND = n" takes care of the technical restrictions.
Yep, that's what I mentioned as Kconfig dependency :) > I am testing the patch now. No ALSA, no volume subdriver, module still > works (and prints some crap to syslog so that the user knows the driver > could do more with ALSA support). > > > It'd be also not nice if suddenly a certain functionality disappears > > without warning (even if the subsystem is enabled but as a module). > > The warning will be there. Although I don't warn of missing rfkill > functionality if the kernel is missing the rfkill subsystem... The messages could be KERN_INFO instead of KERN_WARNING, I think. thanks, Takashi ------------------------------------------------------------------------------ This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers http://p.sf.net/sfu/verizon-dev2dev _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
