On 7/2/20 5:30 PM, Andy Shevchenko wrote:
> On Thu, Jul 2, 2020 at 11:55 AM Aaron Ma <aaron...@canonical.com> wrote:
>>
>> When _BCL invalid, disable thinkpad_acpi backlight brightness control.
>>
>> brightness_enable is already checked at the beginning,
>
>> Always print notice when enabled brightness control.
>
> Why?
>
Default brightness_enable = 2, so this message will always be printed as before
Actually no change here.
> ...
>
>> + pr_notice("thinkpad_acpi native brightness control enabled\n");
>
> 'notice' level is quite high, why do we spam users with this?
>
Like above.
Another reason is most thinkpads are using native gpu driver to control
brightness, notice when thinkpad_acpi brightness is enabled.
Aaron
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
