Mark, I rebooted back into the default Debian (sid) 6.0.6-2 linux image and I do see the `thinkpad_acpi: secondary fan control detected & enabled` message. Is there a recommendation from lenovo for thinkfan ( https://github.com/vmatare/thinkfan) config - or another fan control tool - for X1 Extreme Gen 4i (20Y5007HUS)? I have tried quite a few different configurations, and figured that maybe the quirk needed to be specifically enabled. It either runs really hot or sounds like a jet engine.
-Bryan On Mon, Nov 7, 2022 at 2:09 PM Mark Pearson <mpearson-len...@squebb.ca> wrote: > Hi Bryan > > In theory that shouldn't be needed - I added some auto detection code to > the driver a little while back: > > https://github.com/torvalds/linux/commit/bf779aaf56ea23864e39e9862b3b3a8436236e07 > And specifically removed the P1 G4 there as I'd tested it and the 2nd fan > was auto-detected on my system. > > I take it that's not working on your system? Can we debug it and > understand why? I really wanted to get away from having to add more and > more quirks as more platforms were added. > > Mark > Note - moved to a new email address as I was fedup with Outlook. I'm the > same person as markpear...@lenovo.com :) > > > ------------------------------ > > *From:* Bryan Hundven <bryanhund...@gmail.com> > *Sent:* November 7, 2022 14:16 > *Subject:* [External] [ibm-acpi-devel] [PATCH] platform/x86: > thinkpad_acpi: Add fan quirk to X1 Extreme 4th Gen > > P1/X1 Extreme 4th Gen needs 2nd Controller fan quirk. > > Signed-off-by: Bryan Hundven <bryanhund...@gmail.com> > --- > drivers/platform/x86/thinkpad_acpi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c > b/drivers/platform/x86/thinkpad_acpi.c > index 20e5c043a8e8..2c8a25950fc9 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -8825,6 +8825,7 @@ static const struct tpacpi_quirk fan_quirk_table[] > __initconst = { > TPACPI_Q_LNV3('N', '2', 'N', TPACPI_FAN_2CTL), /* P53 / P73 */ > TPACPI_Q_LNV3('N', '2', 'E', TPACPI_FAN_2CTL), /* P1 / X1 > Extreme (1st gen) */ > TPACPI_Q_LNV3('N', '2', 'O', TPACPI_FAN_2CTL), /* P1 / X1 > Extreme (2nd gen) */ > + TPACPI_Q_LNV3('N', '4', '0', TPACPI_FAN_2CTL), /* P1 / X1 Extreme > (4th gen) */ > TPACPI_Q_LNV3('N', '3', '0', TPACPI_FAN_2CTL), /* P15 (1st gen) > / P15v (1st gen) */ > TPACPI_Q_LNV3('N', '3', '7', TPACPI_FAN_2CTL), /* T15g (2nd gen) > */ > TPACPI_Q_LNV3('N', '1', 'O', TPACPI_FAN_NOFAN), /* X1 Tablet (2nd > gen) */ > -- > 2.38.1 > > > >
_______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
