Thanks Ilpo, On Thu, May 8, 2025, at 10:01 AM, Ilpo Järvinen wrote: > On Wed, 7 May 2025, Mark Pearson wrote: > >> Move all Lenovo specific files into their own sub-directory as part >> of clean-up exercise. >> Longer term goal is to break-up thinkpad_acpi to improve maintainability >> and perhaps share more functionality with other non thinkpad Lenovo >> platforms. >> >> Signed-off-by: Mark Pearson <mpearson-len...@squebb.ca> >> --- >> Some questions that I didn't want to put in the commit comment: >> >> - I didn't know if now was a good time to propose this change. I >> realise it could cause headaches for anybody with patches being >> worked on. > > Don't worry too much about other changes, if you don't recall anything > immediately, there likely isn't anything that significant. If we always > postpone useful reorganizations in fear that some hypothetical work would > have to rebase, it never gets done :-). > >> Please let me know what makes it easiest for maintainers >> and other developers. If there is a particular branch that would be >> better to do this against also let me know. > > Once I've merged fixes branch into for-next (I should do that at latest > early next week if not already this week), it should be pretty > straightforward to handle such move without conflicts. >
OK - thanks. If there's anything I can do to help let me know. >> - Should I be updating the MAINTAINERS file? I'm still not sure what >> the protocol there is. I'm very happy to help review anything in the >> lenovo directory, but I didn't want to make assumptions. > > You should certainly update MAINTAINERS in the same patch to the new > paths. If you want to make other changes, put them such as add your name > into some entry or create a generic LENOVO entry, put those into own > patch after the move please. > OK - I'll submit a v2 with that change. Thanks for the guidance >> - I have tested on multiple platforms but I don't have any ideapads I >> can use. > > Given it's just moves file to new place, the threat of breaking something > that isn't detected by simple build test, isn't that high. > Agreed - thanks for the review. Mark _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
