Hi Andy On Thu, Jun 5, 2025, at 1:58 AM, Andy Shevchenko wrote: > On Wed, Jun 04, 2025 at 01:36:53PM -0400, Mark Pearson wrote: >> Create lenovo subdirectory for holding Lenovo specific drivers. > > ... > >> -F: drivers/platform/x86/lenovo-wmi-hotkey-utilities.c >> +F: drivers/platform/x86/lenovo/lenovo-wmi-hotkey-utilities.c > > You may follow the trick in the Makefile (see intel folder) to avoid > repetition > of the folder name in the file names. Note, the modules will be called the > same (assuming no ABI breakages due to renames). > Interesting - I'll have to look at that a bit more. Any objections if I leave that for a future change?
> ... > >> -# IBM Thinkpad and Lenovo >> +# IBM Thinkpad > > This is a bit ambiguous now. It's IBM and Lenove for ThinkPad... Perhaps you > should put some kind of date or so? Like > > # IBM Thinkpad (before 2007) > > (note, I speculated on the year, you may know better what to put there). > Sure. Realistically the thinkpad_acpi driver still works for the (pretty old now!) IBM Thinkpads so it's a bit messy. Main reason I did this is those two IBM specific drivers aren't, to my understanding, active for Lenovo devices now, and it seemed wrong to move them. Not sure if anybody really cares though :) I just didn't want to step on any toes. IBM sold the PC business to Lenovo in 2005, so I can put that date there unless anybody else has concerns. > ... > >> +++ b/drivers/platform/x86/lenovo/Makefile >> @@ -0,0 +1,15 @@ >> +# SPDX-License-Identifier: GPL-2.0 >> +# >> +# Makefile for linux/drivers/platform/x86/lenovo >> +# Lenovo x86 Platform-Specific Drivers >> +# >> +obj-$(CONFIG_IDEAPAD_LAPTOP) += ideapad-laptop.o >> +obj-$(CONFIG_LENOVO_WMI_HOTKEY_UTILITIES) += lenovo-wmi-hotkey-utilities.o >> +obj-$(CONFIG_LENOVO_YMC) += lenovo-ymc.o >> +obj-$(CONFIG_THINKPAD_ACPI) += thinkpad_acpi.o >> +obj-$(CONFIG_THINKPAD_LMI) += think-lmi.o >> +obj-$(CONFIG_YOGABOOK) += lenovo-yogabook.o >> +obj-$(CONFIG_YT2_1380) += >> lenovo-yoga-tab2-pro-1380-fastcharger.o >> +obj-$(CONFIG_LENOVO_WMI_CAMERA) += lenovo-wmi-camera.o > >> + >> + > > No need to have even a single blank line at the end of file. Usually editors > even complain about this. > My bad - I missed this one. Will fix in v2. Thanks for the review Mark _______________________________________________ ibm-acpi-devel mailing list ibm-acpi-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
