It is not at all a bad subroutine. In many contexts the form of the second argument would be gratuitously clumsy, but this routine was (almost certainly) intended to be called from COBOL, and eight '0' or '1' characters is appropriate for COBOL.
I would not myself have used assembler mnemonics, whicjh are not very perspicuous for COBOL programmers, to identify which operation is to be performed,;and linear search is not the best way to identify which of them has been supplied; but these are quibbles. Joel Ewing's comment: <begin extract> Although the characters in the MASK field are obviously intended to be "0" or "1", no explicit test for "0" is done and any character other than "1" will be interpreted as a "0". </end extract> is apposite, and this defect should be addressed using an early TRT. John Gilmore, Ashland, MA 01721 - USA ---------------------------------------------------------------------- For IBM-MAIN subscribe / signoff / archive access instructions, send email to [email protected] with the message: INFO IBM-MAIN
