On Wed, 15 Oct 2014 02:04:59 -0500, Elardus Engelbrecht wrote:
>
>>>parm.1="/userhome/sa/myrexx.rx"
>>>parm.1="myrexx.rx"
>
>Hmm, I looked again at that posted code and found many such double assignments.
> 
I frequently do similarly for testing:

    /* Second assignment prevails.  (Comments are good!)  */
    parm.1 = "parm for testing"
    parm.1 = "parm for production"

... and simply swap the two lines to switch to testing mode.  No need
to comment.

>In fact, the first parm.1 could be deleted or commented out. But the second 
>one is not looking 'right' for me too.
>
Can't tell out of context.

>I'm also not comfortable with this snippet:
>                              
>"pipe p2fd."                                      
>pipe2out = p2fd.2                                 
>pipe2in = p2fd.1                                  
>map.0=-1                                          
>map.0=pipe2in          
>
>What if p2fd.1 is not numeric? Then you cannot use map.0
> 
If SYSCALL "pipe p2fd." succeeds, it sets p2fd.1 and p2fd.2 to
numeric values.  It might be prudent to check status in RC and
RETVAL.

>The OP needs to ask for help + review for his REXX program.
> 
On review I'm satisfied with the excerpts posted.

-- gil

----------------------------------------------------------------------
For IBM-MAIN subscribe / signoff / archive access instructions,
send email to [email protected] with the message: INFO IBM-MAIN

Reply via email to