On Sun, May 31, 2009 at 9:51 AM, Hideaki ABE <[email protected]> wrote:
> > 2009/5/30 Peng Huang <[email protected]>: > > Hi Hideaki > > Hi Peng > > > Thanks for your work. I have tried your patch. It works, and the setup > > dialog looks very good. But I found one problem: The Escape key can not > work > > with your patch. > > Please, Use the following patch. > ========== > diff --git a/engine/engine.py b/engine/engine.py > index e1024fe..f31fbd5 100644 > --- a/engine/engine.py > +++ b/engine/engine.py > @@ -1108,10 +1108,15 @@ class Engine(ibus.EngineBase): > pass > > def __cmd_cancel(self, keyval, state): > - if not self.__preedit_ja_string.is_empty() and \ > - self.__convert_mode == CONV_MODE_OFF: > + if self.__preedit_ja_string.is_empty(): > + return False > + > + if self.__convert_mode == CONV_MODE_OFF: > return self.__on_key_escape() > - return False > + else: > + self.__end_convert() > + self.__invalidate() > + return True > > def __cmd_cancel_all(self, keyval, state): > return self.__cmd_cancel(keyval, state) > ========== This patch fixed escape problem. Thanks. > > > > BTW, I don't understand Japanese, so maintain the anthy engine is very > > difficult for me, and I can not test your patch in details. :( If you > could > > help me to develop the anthy engine for ibus, it will be great. :) Next > > week, I will build your patch for fedora, and ask some Japanese users to > > test it. Wish we will get more feedbacks form them. > > I want to implement some features for ibus-anthy. > When completing it, I will send it to you. Great! BTW, It will be better if you could share your code in some public git hosting server instead of sending the patch. Thanks Peng Huang --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "ibus-devel" group. iBus project web page: http://code.google.com/p/ibus/ iBus dev group: http://groups.google.com/group/ibus-devel?hl=en -~----------~----~----~----~------~----~------~--~---
