Comment #2 on issue 671 by courtjestr: Patch to add delete-surrounding
functionality and fix forward-key-event
http://code.google.com/p/ibus/issues/detail?id=671
Attached is a new patch file for your evaluation. It addresses issues 1, 2,
4, and 5.
A couple of notes. While I agree with point 2, I did not pull a1 and a2 out
of a hat.
I was following the pattern found in client/gtk2/ibusimcontext.c where the
function
_slave_delete_surrounding_cb also uses a1 and a2. My patch fixes this
readability issue.
Regarding issue 3, a segmentation fault occurs if gdk_event_free is left in
the code.
This is true for both the xim and the gtk client. For the gtk client a
double free
error occurs. For the xim client, an X Error: BadWindow (invalid Window
parameter)
occurs indicating that the event data has been corrupted. Neither of these
errors
occur is the gdk_event_free is removed from the code.
I need to do some more thinking about 6. I am not sure gtk has a
notification event
when the context is changed so this would have to be implemented somehow. I
guess the
issue is that ibus currently does not have a mechanism for the input method
to query
the client app and get a response back, so the qt notification option is
currently
the only way to get context information to the engine. Is this a correct
evaluation?
Doug.
Attachments:
ibus-delete-surrounding-forward-key-event-take2.patch 14.6 KB
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google
Groups "ibus-devel" group.
iBus project web page: http://code.google.com/p/ibus/
iBus dev group: http://groups.google.com/group/ibus-devel?hl=en
