Comment #8 on issue 1188 by [email protected]: Cannot use cangjie
for traditional Chinese if desktop language is set to English
http://code.google.com/p/ibus/issues/detail?id=1188
If piggybacking to 'languages' property would cause some problems, we may
use a new property to specify the default Chinese mode.
How about "language_filter"?
(the current "Chinese mode" wording feels weird to me: Cangjie and Quick
are designed to input both Chinese and Japanese, and other input methods
could probably reuse that for the same kind of language filtering)
And Yes, we need to change the defaults of db file, once we agree on the
property namespace allocation and default value, patches or pull requests
to my fork of ibus-table-chinese are always welcomed.
https://github.com/maxiaojun/ibus-table-chinese
cm3 for Cangjie/Quick makes sense for me too
I'm glad we agree on this.
So, I've tried forking your repo, but then I realized I don't have my
GitHub SSH key here with me so I can't push. :)
To avoid stalling this bug, I uploaded the necessary patches somewhere you
can access them.
Note that I used "language_filter", as I proposed just above. I think it
makes sense to not reuse the existing "languages" property, but I certainly
won't fight over it. Changes to my patches will be trivial if you want to
use another name. :)
1. Add the new property (with the agreed upon value) to the tables:
http://bochecha.fedorapeople.org/patches/0001-Add-a-new-property-to-the-Cangjie-and-Quick-tables-L.patch
(based on maxiaojun/ibus-table-chinese)
2. Add the new property to the IBus Table engine:
http://bochecha.fedorapeople.org/patches/0001-Add-a-new-potential-property-for-tables-language_fil.patch
(based on maxiaojun/ibus-table)
And while I was at it, a trivial (but unrelated to this specific bug) patch
to make the code a tiny little bit prettier:
http://bochecha.fedorapeople.org/patches/0001-Drop-unused-variable-chain-two-string-manipulations.patch
Any chance this gets fixed in the next release? :)
--
You received this message because you are subscribed to the Google
Groups "ibus-devel" group.
iBus project web page: http://code.google.com/p/ibus/
iBus dev group: http://groups.google.com/group/ibus-devel?hl=en
