(07/13/13 21:57), Osamu Aoki-san wrote:
The build path calculation may be refined to accommodate flexible build  with 
attached patch.

Please refer http://code.google.com/p/ibus/issues/detail?id=1312


The two attached patches for format string should fix compile error and improve 
security. (Debian uses -Werror=format-security and these were needed
for compile.  Considering how these strings are generated, risk is practically 
zero but compiler is noisy and making them quiet is easy.)

I don't understand which security issue is fixed with your patches.
I think the formats of the g_dbus function and printf are same.
Does your compiler asks not to use printf(format) for example?

If the similar patches had been upstreamed, e.g. GNOME, KDE, I'd like to know 
the references.

It seems your compiler is not GCC.
% gcc -o c c.c -Werror=format-security
cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
cc1: some warnings being treated as errors


Osamu

PS: Is the web mail is the only way for this ML?

I think it would be better to file a issue instead of attaching patches in the 
mailing list.
http://code.google.com/p/ibus/issues/

--
--
You received this message because you are subscribed to the Google
Groups "ibus-devel" group.
iBus project web page: http://code.google.com/p/ibus/
iBus dev group: http://groups.google.com/group/ibus-devel?hl=en
--- You received this message because you are subscribed to the Google Groups "ibus-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


回复