Author: ruchith
Date: Sat Mar  1 03:04:58 2008
New Revision: 14386

Log:

Getting rid of a few redundant null checks, thanks findbugs

Modified:
   
trunk/solutions/identity/modules/identity-provider/src/main/java/org/wso2/solutions/identity/users/IdentityDefaultUserStoreReader.java

Modified: 
trunk/solutions/identity/modules/identity-provider/src/main/java/org/wso2/solutions/identity/users/IdentityDefaultUserStoreReader.java
==============================================================================
--- 
trunk/solutions/identity/modules/identity-provider/src/main/java/org/wso2/solutions/identity/users/IdentityDefaultUserStoreReader.java
      (original)
+++ 
trunk/solutions/identity/modules/identity-provider/src/main/java/org/wso2/solutions/identity/users/IdentityDefaultUserStoreReader.java
      Sat Mar  1 03:04:58 2008
@@ -77,8 +77,7 @@
                 props.put(name, value);
             }
 
-            if (sqlStatement != null)
-                sqlStatement.close();
+            sqlStatement.close();
 
         } catch (SQLException e) {
             log.debug(e);
@@ -126,8 +125,7 @@
             }
             propNames = (String[]) lst.toArray(new String[lst.size()]);
 
-            if (sqlStatement != null)
-                sqlStatement.close();
+            sqlStatement.close();
 
         } catch (SQLException e) {
             log.debug(e);
@@ -176,8 +174,7 @@
                 name = rs.getString(1);
             }
 
-            if (sqlStatement != null)
-                sqlStatement.close();
+            sqlStatement.close();
 
         } catch (SQLException e) {
             log.debug(e);
@@ -227,8 +224,7 @@
                 profileNames.add(rs.getString(1));
             }
 
-            if (sqlStatement != null)
-                sqlStatement.close();
+            sqlStatement.close();
 
         } catch (SQLException e) {
             log.debug(e);
@@ -280,8 +276,7 @@
                 props.put(name, value);
             }
 
-            if (sqlStatement != null)
-                sqlStatement.close();
+            sqlStatement.close();
 
         } catch (SQLException e) {
             log.debug(e);

_______________________________________________
Identity-dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/identity-dev

Reply via email to