Author: ruchith
Date: Sun Mar 2 02:59:31 2008
New Revision: 14406
Log:
more findbugs fixes
Modified:
trunk/solutions/identity/modules/admin-ui/src/main/java/org/wso2/solutions/identity/admin/ui/UIUtils.java
trunk/solutions/identity/modules/identity-provider/src/main/java/org/wso2/solutions/identity/admin/RealmConfigAdmin.java
Modified:
trunk/solutions/identity/modules/admin-ui/src/main/java/org/wso2/solutions/identity/admin/ui/UIUtils.java
==============================================================================
---
trunk/solutions/identity/modules/admin-ui/src/main/java/org/wso2/solutions/identity/admin/ui/UIUtils.java
(original)
+++
trunk/solutions/identity/modules/admin-ui/src/main/java/org/wso2/solutions/identity/admin/ui/UIUtils.java
Sun Mar 2 02:59:31 2008
@@ -32,7 +32,7 @@
BufferedInputStream buff = new BufferedInputStream(new
FileInputStream(inFile));
- Long len = new Long(inFile.length());
+ Long len = Long.valueOf((inFile.length()));
byte[] img = new byte[len.intValue()];
buff.read(img);
Modified:
trunk/solutions/identity/modules/identity-provider/src/main/java/org/wso2/solutions/identity/admin/RealmConfigAdmin.java
==============================================================================
---
trunk/solutions/identity/modules/identity-provider/src/main/java/org/wso2/solutions/identity/admin/RealmConfigAdmin.java
(original)
+++
trunk/solutions/identity/modules/identity-provider/src/main/java/org/wso2/solutions/identity/admin/RealmConfigAdmin.java
Sun Mar 2 02:59:31 2008
@@ -19,6 +19,7 @@
import java.util.Iterator;
import java.util.Map;
import java.util.Set;
+import java.util.Map.Entry;
import org.wso2.solutions.identity.IdentityProviderConstants;
import org.wso2.solutions.identity.IdentityProviderException;
@@ -45,12 +46,12 @@
realmConfig.setName(configName);
db.create(realmConfig);
- Set keys = properties.keySet();
- for (Iterator iterator = keys.iterator(); iterator.hasNext();) {
- String prop = (String) iterator.next();
+ Set entries = properties.entrySet();
+ for (Iterator iterator = entries.iterator(); iterator.hasNext();) {
+ java.util.Map.Entry<String, String> entry = (Entry<String,
String>)iterator.next();
RealmConfigurationPropertyDO propDo = new
RealmConfigurationPropertyDO();
- propDo.setName(prop);
- propDo.setValue((String) properties.get(prop));
+ propDo.setName(entry.getKey());
+ propDo.setValue(entry.getValue());
propDo.setConfig(realmConfig);
db.create(propDo);
}
_______________________________________________
Identity-dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/identity-dev
