Hi,
--- On Wed, Sep 23, 2009 at 10:58 AM, narendra sisodiya
<[email protected]> wrote:
| Here is a "Freedom Script"
| http://freedombucket.googlecode.com/svn/trunk/ConvertAllFlashtoOgg.sh
\--
Some suggestions:
* "install ffmpeg2theora first using"
You can check if ffmpeg2theora is installed in the system from the
script itself.
* SOURCEDIR=$1
You will need to check if the required arguments are passed to the
script. Else, print a usage display, and exit from the script. You
will also need to check if the user running the script has access to
the SOURCEDIR.
* find "$SOURCEDIR" -name "*" -type f -print |while read Filename ;
do
done
exit 0
If 'find' doesn't return anything, you can display a message.
* if [ $RES -eq 0 ] ;
then
fi ;
The ';' is used if the 'then' is used in the same line of the 'if'
statement. Since, you have used 'then' below the 'if', you don't
actually need a ';' there.
* Consider looking at 'else' cases for your 'if' statements too.
* Please put an author name, e-mail address, and a revision number in
the script, if you are not using some source control management tool
for your script.
SK
--
Shakthi Kannan
http://www.shakthimaan.com
--~--~---------~--~----~------------~-------~--~----~
Do you have another question? Click here -
http://groups.google.com/group/iitdlug/post
l...@iitd community mailing list -- http://groups.google.com/group/iitdlug
-~----------~----~----~----~------~----~------~--~---
