Sat, Oct 29, 2005 ve 04:43:26PM -0500, Ryo Chijiiwa napsal: > > > On 10/29/2005, "Ondra Kudlik" <[EMAIL PROTECTED]> wrote: > > >Hi all, > > > >when I was looking for source of problem with message forwarding I > >found these two things: > > > >1/ there is function iil_ReadLine($fp, $size) but $size isn't used > >there. IMHO :) it should be used for fgets instead fixed value, but > >I'm realy realy not sure. Ryo, can you say? Patch with my opinion :) > >is attached. > > Indeed, $size isn't used because the whole point of iil_ReadLine (as > opposed to fgets) is that it can read infinitely long lines (well, > bounded only by memory). I think I left the parameter in there for > compatibility with fgets, and no other reason.
ok, thanks. As i said, i wasn't really sure :) > >2/ in function iil_C_HandlePartBody on line 1818 there is > > > >if ($len > $remaining) substr($line, 0, $remaining); > > > >But substr only return substring and do not directly modify $line, > >so it should look like this: > > > >if ($len > $remaining) $line = substr($line, 0, $remaining); > > > >Patch is attached. This is BUG, but I never mention that it have > >some bad impact :) > > This does appear to be a bug. > > Ryo Should I commit it to cvs? -- .''`. Ondra 'Kepi' Kudlik : :' : Debian GNU/Linux User `. `' `- http://www.nosoftwarepatents.com/cz/m/intro/index.html ------------------------------------------------------- This SF.Net email is sponsored by the JBoss Inc. Get Certified Today * Register for a JBoss Training Course Free Certification Exam for All Training Attendees Through End of 2005 Visit http://www.jboss.com/services/certification for more information _______________________________________________ Ilohamail-devel mailing list Ilohamail-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/ilohamail-devel
