Hi, --- On Sun, May 10, 2009 at 11:38 AM, sky knight <[email protected]> wrote: | Here is the svn link for the project, | | http://webattery.svn.sourceforge.net/viewvc/webattery/ \--
For revision 21: Much better than what it used to be. Some thoughts: * README paragraphs can be aligned to fit within 80 columns. In Emacs, you can go to the line and do, Alt-q. * You updated your code to now use getopt, which is the way it should be done. * You have initialized your global pointers, but, not your local variables or local pointers. * You could move your struct definitions to header files. * Please check function return values. fopen(), for example. * Run a spell-check on your comments. * Appreciate if you could have some consistency in the spacing whether or not you need spacing on either side of the operator: 376: for (i = 0;i <= total_string_len;i++) * "char chuma" == :) * In configure.ac, SRCDIR should be: AC_CONFIG_SRCDIR([src/webattery.c]) * You have used five header files, but, only check for presence of two headers in AC_CHECK_HEADERS. You can include all five of them. AC_CHECK_HEADERS([stdlib.h string.h stdio.h getopt.h dirent.h]) The same applies to AC_CHECK_FUNCS. Remember, the more the function/library checks you do now, the better will be the portability checks, in case you decide to try it on some other system. I suggest you read through this: http://www.freesoftwaremagazine.com/books/autotools_a_guide_to_autoconf_automake_libtool * Put a Changelog, AUTHORS file. SK -- Shakthi Kannan http://www.shakthimaan.com _______________________________________________ To unsubscribe, email [email protected] with "unsubscribe <password> <address>" in the subject or body of the message. http://www.ae.iitm.ac.in/mailman/listinfo/ilugc
