Hi,

On 05/18/2011 07:37 PM, anbazhagan p wrote:
> Dear Friends
>                  I have written a python script to download all videos from
> the railscasts website ,
> and you can check my script in my blog
> http://love-blacky.blogspot.com.Please check my
> script and if there is any error or change to be made in my script please
> let me know.
>
>

Good stuff. A couple of comments:
a. If you intend to share code and are expecting people to contribute back, it 
would be nice to host the code at some code repository like github.com. That 
way 
people can checkout the code, make changes and push back changes to you easily. 
Even for trivial scripts, I would recommend using gist.github.com (which also 
integrates well with blogs).

b. Why are you using wget to download the url ? Use something like the urllib2 
module in the python standard library and your script becomes instantly usable 
by anyone who might have python installed but may not have wget (python 
developers on windows, for instance).

c. For such a small script having an external dependency on BeautifulSoup might 
not be ideal. I would suggest using the re module from the standard lib to do 
your pattern matching and extraction.

If you host the script on github, I'll submit these changes - deal ?

cheers,
- steve

PS: ehe ...I do find it slightly amusing that you went with python to write a 
script to download ruby related webcasts :D !
-- 
random spiel: http://lonetwin.net/
what i'm stumbling into: http://lonetwin.stumbleupon.com/
_______________________________________________
ILUGC Mailing List:
http://www.ae.iitm.ac.in/mailman/listinfo/ilugc

Reply via email to