Hi, --- On Fri, Jun 17, 2011 at 7:23 AM, Gautam <[email protected]> wrote: | I have Uploaded the Source Code at | | https://github.com/gautamk/FFDownloadComplete \--
Quick thoughts: #001 Why do you commit .swp and .pyc files? Git only tracks changes in content. #002 Add a LICENSE file indicating the license under which the sources are released. #003 Add a copyright, header notice in each source file. #004 Run pylint on your *.py and fix the warning/error messages. #005 Any reason to have not used json? You have commented its import in python/register.py http://docs.python.org/library/json.html #006 Please follow PEP8 guidelines. For example: "class names use the CapWords convention". Try to be consistent across your source files. http://www.python.org/dev/peps/pep-0008/ SK -- Shakthi Kannan http://www.shakthimaan.com _______________________________________________ ILUGC Mailing List: http://www.ae.iitm.ac.in/mailman/listinfo/ilugc
