We have two options:
1) break it and maybe it is just fine
2) make a second method like
public ImgPlus< T > wrapImgPlus( final ImagePlus imp )
{
Img< T > img = wrap( imp );
ImgPlus< T > imgplus = new ImgPlus( img );
imgplus.setCalibration( imp.getCal ... );
imgplus.setName( imp.getTitle() );
return imgplus;
}
Maybe 1) is the better way to go, I just wanted to bring up potential
implications ....
On Jul 12, 2012, at 17:14 , Jean-Yves Tinevez wrote:
> On 12-Jul-12 23:05, Stephan Preibisch wrote:
>> In principle, I agree. However it might break some code in a bad way. We
>> used several times constructs like
>>
>> Img< T > img;
>>
>> if ( img instanceOf ImagePlusImg )
>> {
>> // get the underlying instance (which is especially true after wrapping)
>> ImagePlus imp = ((ImagePlusImg)img).getImagePlus();
>> ....
>>
>> // or do something else where you test instanceof
>> }
>>
>> which would suddenly fail because ImgPlus is an Img, but only HAS for
>> example an ImagePlusImg...
>>
>> What do you think?
>
> Bummer.
>
> How do we get the ImagePlusAdapter to return an Img that captures calibration
> as well then?
>
> --
> Please avoid top-posting, and please make sure to reply-to-all!
>
> Mailing list web interface: http://groups.google.com/group/fiji-devel
_______________________________________________
ImageJ-devel mailing list
[email protected]
http://imagej.net/mailman/listinfo/imagej-devel
