On Dec 10, 2009, at 9:32 AM, Neeraj Joshi wrote: > splcore.jar holds the core language parser elements which are specific to > the SPL language. I do not see any > value in making it available on maven. The javaspl.jar and > cimsplclientsideprovider are jars that other projects could potentially > download and embed within their distribution.
OK. As long as the community is ok with this restriction, I'm fine... Here's my +1, again. --kevan > Thanks > Neeraj > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > "It is hard enough to remember my opinions, without also remembering my > reasons for them". -Friedrich Wilhelm Nietzsche > > Neeraj Joshi (knee-rudge) > WebSphere XD - Compute Grid > AIM, IBM > Apache Imperius - http://incubator.apache.org/imperius > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > From: > Kevan Miller <kevan.mil...@gmail.com> > To: > imperius-dev@incubator.apache.org > Date: > 12/10/2009 08:51 AM > Subject: > Re: [VOTE] Imperius 1.0.0 rc6 > > > > > Nice review, Erik. A few comments... > > On Dec 10, 2009, at 7:23 AM, Erik Bengtson wrote: > >> +1 >> >> Some remarks: >> >> - In the zip/tar file we have a /log.txt file that should be removed. >> - Inside the jars we have a /META-INF/maven that should be removed too. >> - imperius-splcore-1.0.0.jar does not have NOTICE.txt and LICENSE.txt > > This could be a release blocker. As long as the jar is only packaged > within an Imperius binary distribution (which does have LICENSE/NOTICE), > then that's OK. However, in the days of Maven and separately downloadable > artifacts, individual artifacts need to be appropriately licensed, > themselves. > > Based on this, I'm changing my vote to a -1... > > If we're convinced that imperius-splcore-1.0.0.jar will never be deployed > to maven, then I can probably be convinced otherwise... > >> - IMO, the lib/javaspl-samples-1.0.0.jar should be moved to >> samples/lib/javaspl-samples-1.0.0.jar >> - IMO, NOTICE.txt and LICENSE.txt files in jar files should lie in >> META-INF folder. > > Right again. Not sure if this violates ASF policy or not. But META-INF is > the right location. > > --kevan > >> >> On Fri, Dec 4, 2009 at 4:04 PM, Neeraj Joshi <jnee...@us.ibm.com> wrote: >>> Hi All, >>> >>> The Imperius 1.0.0 RC6 release candidate has been tagged, packaged, >>> and is ready for a vote. The artifacts, KEYS file, RAT report and > release >>> notes can >>> be found at >>> >>> http://people.apache.org/~jneeraj/apache-imperius-1.0.0-rc6/ >>> >>> The tag from which the release artifacts were generated can be found >>> at >>> >>> > http://svn.apache.org/repos/asf/incubator/imperius/tags/release1.0.0rc6/ >>> >>> Revision no is 887217 >>> >>> In addition, my PGP public code signing key can be found at the MIT >>> key server (http://pgp.mit.edu/) >>> >>> The KEYS file is checked in at >>> http://svn.apache.org.repos/asf/incubator/imperius/KEYS >>> >>> Please vote to publish this release by Tuesday, Dec 08 18:00 EST., >>> please include the testing you performed to arrive at your vote >>> [ ] +1 Publish >>> [ ] 0 Abstain >>> [ ] -1 Don't publish, because... >>> >>> Upon a positive majority of binding votes and no binding vetoes, the >>> results of this vote will be brought to the Incubator PMC and voted >>> upon there. >>> >>> Thanks, >>> -Neeraj >>> >>> Change log: >>> 1. Checked in the build.xml from the release artifact into the SVN tag. >>> All the release artifacts >>> from previous candidate (r5) are the same. >>> 2. Updated the SVN revision number. >>> 3. Left the redundant zip/gz files as is. >>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >>> "It is hard enough to remember my opinions, without also remembering my >>> reasons for them". -Friedrich Wilhelm Nietzsche >>> >>> Neeraj Joshi (knee-rudge) >>> WebSphere XD - Compute Grid >>> AIM, IBM >>> Apache Imperius - http://incubator.apache.org/imperius >>> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > >
