Do you have a written description of the logic you are intending to use?
If you only consider ways where none of the child nodes have been moved as potential candidates for geometry changes this will avoid the self-intersecting way problem. The self-intersecting way problem is not confined to cases where someone has moved an OSM node to an incorrect location. I see two obvious cases 1. The TIGER 2012 geometry is wrong. 2. You mix two geometries which are right, but ordering problems lead to a self-intersecting or badly wrong geometry. See http://3.bp.blogspot.com/-apHSW0kuiN0/UIczscIpvZI/AAAAAAAABW0/KR3gUr_wZEQ/s1 600/redaction_weird_offramp.png from the section on redaction damage on http://ksmapper.blogspot.ca/2012/10/licensed-to-map-what-happened-to-la.html .html for the types of problems. You might need to treat end nodes specially and make sure that the next node in any adjoining ways is also an unmoved TIGER 2005 node. Your code seems to be a mix of graphing code and diff generation code. There is also no instructions for running it. Could you provide .osc files for a couple counties? I know .osc files are hard for most people to review, but they'd help me at least. From: Eric Fischer [mailto:[email protected]] Sent: Saturday, March 16, 2013 6:48 PM To: [email protected] Subject: [Imports-us] Updating TIGER imports in OpenStreetMap to TIGER 2013 Hi everyone. (And sorry to anyone who has already seen the earlier version of this on talk-us.) At the time OpenStreetMap imported the US Census TIGER map data, the Census was in the middle of their "Accuracy Improvement Program" that greatly improved the alignment of TIGER features in many areas for the 2010 census. Many of the more recent TIGER corrections have since also been applied to OpenStreetMap, particularly in major metro areas, but not generally not systematically, and many others, particularly in rural areas, have not been applied. I would like to update OpenStreetMap with as many of the corrections that have been made to TIGER as can be applied to Open StreetMap without altering anything that has been edited directly in OSM. In most cases this just means moving unedited OSM nodes that came from TIGER to the positions that TIGER currently indicates, although in some cases TIGER edges have had nodes added or removed, so the corresponding OSM ways must also have nodes added or removed. I don't propose to delete or move any intermediate points that have been linked to other OSM ways, or to move any nodes that have been moved in OSM since the TIGER import. I also don't propose to change any tags on the nodes or ways. Although this process will never change the topology of the network, it could potentially cause some odd-looking results where someone has moved (but not to the correct location) an OSM node that connects to an updated TIGER node, making streets have abrupt turns or cross over themselves. I think the safe thing to do is not to move any nodes that are connected by a way to a node that is more than a few feet from where TIGER thinks it should be, and to make a separate list of these conflicts that can be manually investigated. There are also many cases where TIGER 2013 knows about streets that were not built or not mapped in TIGER 2006. Some of these have also been added by OSM contributors but many others have not been. I think the right thing to do for these is to generate speculative OSM equivalents, but rather than checking any of them in directly, use something like MapRoulette to review each of them to see whether or not it ought to be adopted. The code I've been writing to generate the .osc XML for these changes, mostly only tested so far on a few Indiana counties, is at <https://github.com/ericfischer/osm-tiger-update> https://github.com/ericfischer/osm-tiger-update A rendering of what the changes look like in those counties is at http://www.flickr.com/photos/walkingsf/8562893003/ Please let me know what you think of the idea and if there is a better way to do it. Thanks, Eric
_______________________________________________ Imports-us mailing list [email protected] http://lists.openstreetmap.org/listinfo/imports-us
