Hi, Andrew:

Thank you for all this work that, when finished, will improve a lot the administrative boundaries data of OSM in Australia.

I've been looking only a bit inside the data (file 1.osm) and I have some issues/questions:

Running the JOSM validator, it throws the following errors and warnings:

Errors:

2,384 duplicated way nodes.
864 intersection between multipolygon ways.
40 multipoligon members repeated with same role (they seem to be duplicated nodes as well)
And 1 way contains twice a segment.

Warnings:

43,708 crossing boundaries
3 overlapping ways
15 self-crossing ways
1,156 self-intersecting polygon rings, and
51 self-intersecting ways

All these errors and warnings should be fixed before importing, and you should document how you will proceed to fix them in the import wiki.

I've seen that border ways aren't tagged. At least they should have the following tags [1]:

boundary=administrative
admin_level="the highest (lowest number) level it shares"

Adding source=* to those ways is also recommended.

Between the admin_level=6 Willoughby City and Ryde City councils, along the Lane Cove river, I see that the river basin is an admin_level_6 "council" called "Unincorporated". Is that correct? I ask this because I see that the current OSM "Council of the city of Ryde" border (admin_level=6 too) goes along the centre of the river.

I also see that the to-be-imported borders of Willoughby and Ryde city councils don't adapt to the river banks as they are now in OSM. Will things like these be manually conflated with existing OSM data? I don't see that in the wiki yet. Maybe that could be extended from the point "Apply any coastline conflation if using the existing coastline as some of the boundaries (or this can be done post-import)" that you have already in the Workflow section of the wiki, so river banks would be included in that conflation together with coastline.

As for the changeset tags, I would add:

type=import

Although not important, you may consider to change the source to:

source=PSMA_Admin_Boundaries

and add:

source:date=August_2018

The changeset tag review_requested=yes (available as an option already in JOSM (and iD)) may help you if you want to include validation in the workflow.

This is all that I've seen. I hope it can help you.

Have an excellent week,

Rafael.

[1] https://wiki.openstreetmap.org/wiki/Relation:boundary#Way_tags

On 22/10/18 05:53, Andrew Harvey wrote:
The Australian community have been planning an import of
administrative boundaries, we've been discussing and working on the
plan within the local community at
https://lists.openstreetmap.org/pipermail/talk-au/2018-October/thread.html.

We're at the stage now where we would appreciate an import review per
the import guidelines. All feedback/comments are most welcome.

Documentation on the import is being curated at
https://wiki.openstreetmap.org/wiki/Import/Catalogue/PSMA_Admin_Boundaries

_______________________________________________
Imports mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/imports


_______________________________________________
Imports mailing list
[email protected]
https://lists.openstreetmap.org/listinfo/imports

Reply via email to