On Wed, Jul 26, 2017 at 1:04 PM, Jonah Graham <[email protected]>
wrote:

> GitHub does not preserve the
> intermediary versions of the source, even if they have been reviewed.
> If the comments are commit comments (common flow many people use) then
> then comments are lost too.
>

This has changed about a year ago IIRC. Comments are preserved on the PR,
with the line association and so on. See
https://github.com/mickaelistria/aCute/pull/23 for an example of comments
being made on a commit, and then commit being replaced with `git push
--force`. The initial comments are still there.
IIRC, GitHub now even keeps the intermediary commit in the repo as long as
the PR isn't closed.


-- 
Mickael Istria
Eclipse IDE <https://www.eclipse.org/downloads/eclipse-packages/>
developer, at Red Hat Developers <https://developers.redhat.com/> community
_______________________________________________
incubation mailing list
[email protected]
To change your delivery options, retrieve your password, or unsubscribe from 
this list, visit
https://dev.eclipse.org/mailman/listinfo/incubation

Reply via email to