Hi Kevin, This will probably need to be done on the github project, per each prject separately.
Github supports "protecting" branches - https://help.github.com/articles/about-protected-branches/ - which, among other things, requires at least one approval before a PR can be merged. It also requires that validation checks are passed, which isnt currently enforced right now I think, making it possible to merge a PR even if Eclipse IP checks fail. We probably need to raise a bug for Eclipse admins to protect master branches for each repo we need, and also remember to do it when requesting a new repo. Ondro 2017-09-06 16:30 GMT+02:00 Kevin Sutter <[email protected]>: > Hi, > We would like to require at least one review of any PRs before merging. > How do we go about making this type of configuration change for our Eclipse > github repos? I've searched the Handbook and I see references to Gerrit, > but we're not looking for anything that "elaborate". Just a simple > Protection update to require a review before merging. > > Thanks, > Kevin > Eclipse MicroProfile > > _______________________________________________ > incubation mailing list > [email protected] > To change your delivery options, retrieve your password, or unsubscribe > from this list, visit > https://dev.eclipse.org/mailman/listinfo/incubation > >
_______________________________________________ incubation mailing list [email protected] To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://dev.eclipse.org/mailman/listinfo/incubation
