-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 03/08/2013 06:47 PM, Greg Kroah-Hartman wrote: > On Fri, Mar 08, 2013 at 09:21:45AM +0100, Samuel Iglesias > Gonsalvez wrote: >> Signed-off-by: Samuel Iglesias Gonsalvez <sigles...@igalia.com> >> --- drivers/ipack/ipack.c | 1 + 1 file changed, 1 >> insertion(+) >> >> diff --git a/drivers/ipack/ipack.c b/drivers/ipack/ipack.c index >> 7ec6b20..599d4ff 100644 --- a/drivers/ipack/ipack.c +++ >> b/drivers/ipack/ipack.c @@ -24,6 +24,7 @@ static void >> ipack_device_release(struct device *dev) { struct ipack_device >> *device = to_ipack_dev(dev); kfree(device->id); + device->id = >> NULL; > > How does that keep anything from being freed twice? > >> device->release(device); > > device should now be gone after this call, right? What am I > missing? >
Yes, you are right. It's not possible to have it freed twice once it's in ipack_device_release(). You can skip this patch. If you want, I can resend the others accordingly. Sam -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQIcBAEBCAAGBQJROim2AAoJEH/0ujLxfcNDY+sQAMfrjjs05FJ9wmQvqEFKg18I QVddG8BbHKDzdmSTkDlagijTE/Q7eOOFV7zOKz6QWJjO14ktPjr56cFwEmIl0KPj LcDO4+4bIsOfhO64ZJ7CHUFyMcq3olrZNBhQLJZU1anOcDKIimzomGGPXv5PPFe6 BXnRNeXEnS81r3LXQtlJM7h8th3objKWW2R5No40E9sHIKWEgYR7JmgCqhk0fQNv RKA9FjyBFpF8RjPoi+xSdPYhFPLpOv99ZbYK1wU4goD4ADw9Npujw/66CjFtgJGx BH3MquLaCYvCmJK6+obQJzWKl1TonQ153hh6uM1b7h+5RJ4yhUSaSPRLLIWGAxRH 3XlbtjMO6bwEDAEg2hOq9whmoVxK70YvjKOCkqo8crwqVsLccMnv4OzoE4NNrm99 8cdUScK8cTi5fg2HuIEJMVTPxpfLk46Ab3OTO9hoVURyRG84TnJ0SLK0CPzy6J1z ORgZWh7PlEsgLeqsqjKv7q/5tcLLPEGZcV7TekWPBfNVR5aneemHrEIaSIuVYXxw a7INgvaAWNhqGhag86KwVH0ICbz2xuJu6wtrlFhyMZWhdPN5aEcHwXusjUBhrdrm DXoEDBFvJShBE8PxNPWYIBcrphetaSQzl0vNsO/SqacGlppsAqtvvU6hkkAuhGeO a8dpR7nIR8tuz4NPnFHu =NypR -----END PGP SIGNATURE----- ------------------------------------------------------------------------------ Symantec Endpoint Protection 12 positioned as A LEADER in The Forrester Wave(TM): Endpoint Security, Q1 2013 and "remains a good choice" in the endpoint security space. For insight on selecting the right partner to tackle endpoint security challenges, access the full report. http://p.sf.net/sfu/symantec-dev2dev _______________________________________________ Industrypack-devel mailing list Industrypack-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/industrypack-devel