On Thu, 2014-07-03 at 10:53 +0200, Federico Vaga wrote: > The request for an IRQ handler must be done after whole configuration. This > was not the case for this driver which request the IRQ in the middle of > the configuration. Sometimes, it happens that something is not completely > configured, we recieve an interrupt thus we stumble into troubles in the > IRQ handler. > > Signed-off-by: Federico Vaga <federico.v...@cern.ch> > --- > drivers/ipack/devices/ipoctal.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > > diff --git a/drivers/ipack/devices/ipoctal.c b/drivers/ipack/devices/ipoctal.c > index a7ec6f9..72fd761 100644 > --- a/drivers/ipack/devices/ipoctal.c > +++ b/drivers/ipack/devices/ipoctal.c > @@ -344,13 +344,6 @@ static int ipoctal_inst_slot(struct ipoctal *ipoctal, > unsigned int bus_nr, > &block_regs[i].w.imr); > } > > - /* > - * IP-OCTAL has different addresses to copy its IRQ vector. > - * Depending of the carrier these addresses are accesible or not. > - * More info in the datasheet. > - */ > - ipoctal->dev->bus->ops->request_irq(ipoctal->dev, > - ipoctal_irq_handler, ipoctal); > /* Dummy write */ > iowrite8(1, ipoctal->mem8_space + 1); > > @@ -411,6 +404,14 @@ static int ipoctal_inst_slot(struct ipoctal *ipoctal, > unsigned int bus_nr, > dev_set_drvdata(tty_dev, channel); > } > > + /* > + * IP-OCTAL has different addresses to copy its IRQ vector. > + * Depending of the carrier these addresses are accesible or not. > + * More info in the datasheet. > + */ > + ipoctal->dev->bus->ops->request_irq(ipoctal->dev, > + ipoctal_irq_handler, ipoctal); > + > return 0; > } >
Acked-by: Samuel Iglesias Gonsalvez <sigles...@igalia.com> Greg, Would you mind picking this patch through your driver-core tree? Together with "ipoctal: protect only the real critical section" patch. Thanks, Sam
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------------ Open source business process management suite built on Java and Eclipse Turn processes into business applications with Bonita BPM Community Edition Quickly connect people, data, and systems into organized workflows Winner of BOSSIE, CODIE, OW2 and Gartner awards http://p.sf.net/sfu/Bonitasoft
_______________________________________________ Industrypack-devel mailing list Industrypack-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/industrypack-devel
